pkg/analysis_services/lib/src/completion/local_computer.dart - Issue 459853003: remove duplicate suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/lib/src/completion/local_computer.dart

Issue 459853003: remove duplicate suggestions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix suggestion notification processing in test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_services/lib/src/completion/local_computer.dart

diff --git a/pkg/analysis_services/lib/src/completion/local_computer.dart b/pkg/analysis_services/lib/src/completion/local_computer.dart

index bfc2f6f2a1708d42d33cea8c1c7a63279fa8a5e0..8a6799d24099e217a17d11ebd75ac4f19395f57d 100644

--- a/pkg/analysis_services/lib/src/completion/local_computer.dart

+++ b/pkg/analysis_services/lib/src/completion/local_computer.dart

@@ -153,7 +153,8 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {

}

visitFunctionDeclaration(FunctionDeclaration node) {

- addSuggestion(node.name, CompletionSuggestionKind.FUNCTION);

+ // This is added by the compilation unit containing it

+ //addSuggestion(node.name, CompletionSuggestionKind.FUNCTION);

visitNode(node);

}