Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 458073002: rename and improve imported completion computer (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

rename and improve imported completion computer BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39081

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -161 lines) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analysis_services/lib/src/completion/dart_completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_services/lib/src/completion/imported_type_computer.dart View 2 chunks +29 lines, -7 lines 0 comments Download
D pkg/analysis_services/lib/src/completion/top_level_computer.dart View 1 chunk +0 lines, -65 lines 0 comments Download
A + pkg/analysis_services/test/completion/imported_type_computer_test.dart View 3 chunks +16 lines, -4 lines 0 comments Download
M pkg/analysis_services/test/completion/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/analysis_services/test/completion/top_level_computer_test.dart View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-08-11 03:42:39 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-11 03:54:24 UTC) #2
danrubel
6 years, 4 months ago (2014-08-11 12:43:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 39081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698