Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/analysis_services/test/completion/imported_type_computer_test.dart

Issue 458073002: rename and improve imported completion computer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_services/test/completion/imported_type_computer_test.dart
diff --git a/pkg/analysis_services/test/completion/top_level_computer_test.dart b/pkg/analysis_services/test/completion/imported_type_computer_test.dart
similarity index 76%
rename from pkg/analysis_services/test/completion/top_level_computer_test.dart
rename to pkg/analysis_services/test/completion/imported_type_computer_test.dart
index aa19fd2ed652540cce7b8944cd38fc1961d83881..79dca5c9ce195b25bacd5ddfa115363fac8812e3 100644
--- a/pkg/analysis_services/test/completion/top_level_computer_test.dart
+++ b/pkg/analysis_services/test/completion/imported_type_computer_test.dart
@@ -5,7 +5,7 @@
library test.services.completion.toplevel;
import 'package:analysis_services/completion/completion_suggestion.dart';
-import 'package:analysis_services/src/completion/top_level_computer.dart';
+import 'package:analysis_services/src/completion/imported_type_computer.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:unittest/unittest.dart';
@@ -13,16 +13,16 @@ import 'completion_test_util.dart';
main() {
groupSep = ' | ';
- runReflectiveTests(TopLevelComputerTest);
+ runReflectiveTests(ImportedTypeComputerTest);
}
@ReflectiveTestCase()
-class TopLevelComputerTest extends AbstractCompletionTest {
+class ImportedTypeComputerTest extends AbstractCompletionTest {
@override
void setUp() {
super.setUp();
- computer = new TopLevelComputer();
+ computer = new ImportedTypeComputer();
}
test_class() {
@@ -32,6 +32,18 @@ class TopLevelComputerTest extends AbstractCompletionTest {
assertSuggestClass('A');
assertNotSuggested('x');
assertNotSuggested('_B');
+ // Should not suggest compilation unit elements
+ // which are returned by the LocalComputer
+ assertNotSuggested('C');
+ });
+ }
+
+ test_class_importedWithPrefix() {
+ addSource('/testA.dart', 'class A { }');
+ addTestSource('import "/testA.dart" as foo; class C {foo(){^}}');
+ return computeFull().then((_) {
+ // do not suggest types imported with prefix
+ assertNotSuggested('A');
});
}
« no previous file with comments | « pkg/analysis_services/lib/src/completion/top_level_computer.dart ('k') | pkg/analysis_services/test/completion/test_all.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698