Issue 455393003: Do not add forwarding constructors to a pricate constructor from a different library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 455393003: Do not add forwarding constructors to a pricate constructor from a different library. (Closed)

Created:
6 years, 4 months ago by karlklose

Modified:
6 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not add forwarding constructors to a pricate constructor from a different library. BUG= http://dartbug.com/20394 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=39084

Patch Set 2 : Fix long line. #

Total comments: 1

Patch Set 3 : Address comment. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -2 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
A	tests/language/regress_20394_lib.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	tests/language/regress_20394_test.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/455393003/diff/20001/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/455393003/diff/20001/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode755 sdk/lib/_internal/compiler/implementation/typechecker.dart:755: // We neither found a member with the ...

6 years, 4 months ago (2014-08-11 12:50:01 UTC) #2

karlklose

6 years, 4 months ago (2014-08-11 12:55:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as 39084 (presubmit successful).