Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: sdk/lib/_internal/compiler/implementation/typechecker.dart

Issue 455393003: Do not add forwarding constructors to a pricate constructor from a different library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | tests/language/regress_20394_lib.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/typechecker.dart
diff --git a/sdk/lib/_internal/compiler/implementation/typechecker.dart b/sdk/lib/_internal/compiler/implementation/typechecker.dart
index 522e6c272339b83109853bb7e095671dd3005adb..ad1df28633b19442ea24c7f47a1d9e6d60acec98 100644
--- a/sdk/lib/_internal/compiler/implementation/typechecker.dart
+++ b/sdk/lib/_internal/compiler/implementation/typechecker.dart
@@ -752,7 +752,11 @@ class TypeCheckerVisitor extends Visitor<DartType> {
}
}
}
- if (!interface.element.isProxy) {
+ // We didn't find a member with the correct name. If this lookup is for a
+ // super or redirecting initializer, the resolver has already emitted an
+ // error message. If the target is a proxy, no warning needs to be emitted.
+ // Otherwise, try to emit the most precise warning.
+ if (!interface.element.isProxy && !analyzingInitializer) {
bool foundPrivateMember = false;
if (memberName.isPrivate) {
void findPrivateMember(MemberSignature member) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | tests/language/regress_20394_lib.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698