Issue 452713002: Fix Dartium Upload for sha256 sums

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 452713002: Fix Dartium Upload for sha256 sums (Closed)

Created:
6 years, 4 months ago by kaendfinger

Modified:
6 years, 4 months ago

Reviewers:
ricow1, kevmoo

CC:
reviews_dartlang.org, sethladd

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Dartium Upload for sha256 sums R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=39020

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/dartium/upload_steps.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

Committed patchset #1 manually as 39020 (presubmit successful).

6 years, 4 months ago (2014-08-08 03:41:23 UTC) #3

ricow1

6 years, 4 months ago (2014-08-08 06:12:52 UTC) #4

Message was sent while issue was closed.

On 2014/08/08 03:41:23, kevmoo wrote:
> Committed patchset #1 manually as 39020 (presubmit successful).

LGTM, thank you
Ignoring exit codes are bad, this is why this did not show up on the bots, see:
https://codereview.chromium.org/450923002

This should have turned the dartium full bots red, but did not due to that

Expand Messages | Collapse Messages