Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 450923002: Use exitcode of running the annotated steps script (Closed)

Created:
6 years, 4 months ago by ricow1
Modified:
6 years, 4 months ago
Reviewers:
Bill Hesse
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Use exitcode of running the annotated steps script If there is an error in the annotated steps we will still have a green bot!!!! Example: http://chromegw.corp.google.com/i/client.dart/builders/dartium-lucid64-full-be/builds/3566/steps/annotated_steps/logs/stdio TBR=whesse Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=288225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M scripts/slave/chromium/dart_buildbot_run.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
tbr
6 years, 4 months ago (2014-08-08 06:11:19 UTC) #1
ricow1
The CQ bit was checked by ricow@google.com
6 years, 4 months ago (2014-08-08 06:11:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricow@google.com/450923002/1
6 years, 4 months ago (2014-08-08 06:12:04 UTC) #3
commit-bot: I haz the power
Change committed as 288225
6 years, 4 months ago (2014-08-08 06:13:20 UTC) #4
Bill Hesse
6 years, 4 months ago (2014-08-08 07:32:55 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698