Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 451483005: Code generate integration test methods for synchronous request/response pairs. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Code generate integration test methods for synchronous request/response pairs. These methods take care of validating requests and responses (unless the optional argument 'checkTypes' is false); this should make writing integration tests easier and less error-prone. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1181 lines, -76 lines) Patch
M pkg/analysis_server/test/integration/analysis_domain_int_test.dart View 5 chunks +14 lines, -34 lines 0 comments Download
M pkg/analysis_server/test/integration/completion_domain_int_test.dart View 3 chunks +3 lines, -7 lines 0 comments Download
A pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +962 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 3 chunks +4 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/integration/server_domain_int_test.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M pkg/analysis_server/tool/spec/api.dart View 1 chunk +8 lines, -10 lines 0 comments Download
A pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 chunk +180 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-07 00:07:25 UTC) #1
jwren
On 2014/08/07 00:07:25, Paul Berry wrote: LGTM
6 years, 4 months ago (2014-08-07 18:32:42 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-07 20:14:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698