Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: pkg/analysis_server/test/integration/completion_domain_int_test.dart

Issue 451483005: Code generate integration test methods for synchronous request/response pairs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/completion_domain_int_test.dart
diff --git a/pkg/analysis_server/test/integration/completion_domain_int_test.dart b/pkg/analysis_server/test/integration/completion_domain_int_test.dart
index 4621abee956603168ebeab1798eaf3eac4d32144..dc333fbe15e4ba590cf7eff90f9830ccec349941 100644
--- a/pkg/analysis_server/test/integration/completion_domain_int_test.dart
+++ b/pkg/analysis_server/test/integration/completion_domain_int_test.dart
@@ -6,7 +6,6 @@ library test.integration.completion.domain;
import 'dart:async';
-import 'package:analysis_server/src/constants.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:unittest/unittest.dart';
@@ -18,8 +17,7 @@ class CompletionDomainIntegrationTest extends
fail_test_getSuggestions_string_var() {
// See dartbug.com/20188
String pathname = sourcePath('test.dart');
- String text =
- r'''
+ String text = r'''
var test = '';
main() {
test.
@@ -29,10 +27,8 @@ main() {
standardAnalysisRoot();
return analysisFinished.then((_) {
- return server.send(COMPLETION_GET_SUGGESTIONS, {
- 'file': pathname,
- 'offset': text.indexOf('test.') + 'test.'.length
- }).then((result) {
+ return sendCompletionGetSuggestions(pathname, text.indexOf('test.') +
+ 'test.'.length).then((result) {
// Since the feature doesn't work yet, just pause for a second to
// collect the output of the analysis server, and then stop the test.
// TODO(paulberry): finish writing the integration test once the feature

Powered by Google App Engine
This is Rietveld 408576698