Issue 447793003: VM: Micro-optimization of inline array allocation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 447793003: VM: Micro-optimization of inline array allocation code. (Closed)

Created:
6 years, 4 months ago by Florian Schneider

Modified:
6 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

VM: Micro-optimization of inline array allocation code. The loop initializing a newly allocated array now has only one branch, instead of two per iteration. Removed some dead code from flowgraph.cc/.h. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39092

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -43 lines)			Patch
M	runtime/vm/flow_graph.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+12 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+10 lines, -8 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+11 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

Florian Schneider

On 2014/08/07 10:38:22, Florian Schneider wrote: Ping.

6 years, 4 months ago (2014-08-11 09:05:42 UTC) #2

Florian Schneider

6 years, 4 months ago (2014-08-11 15:59:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r39092 (presubmit successful).