Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 447793003: VM: Micro-optimization of inline array allocation code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 38967)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -2043,21 +2043,23 @@
FieldAddress(V0, Array::length_offset()),
kLengthReg);
- __ LoadImmediate(T7, reinterpret_cast<int32_t>(Object::null()));
// Initialize all array elements to raw_null.
// V0: new object start as a tagged pointer.
// T1: new object end address.
// T2: iterator which initially points to the start of the variable
// data area to be initialized.
// T7: null.
- __ AddImmediate(T2, V0, sizeof(RawArray) - kHeapObjectTag);
+ if (num_elements > 0) {
+ __ LoadImmediate(T7, reinterpret_cast<int32_t>(Object::null()));
+ __ AddImmediate(T2, V0, sizeof(RawArray) - kHeapObjectTag);
- Label init_loop;
- __ Bind(&init_loop);
- __ BranchUnsignedGreaterEqual(T2, T1, done);
- __ sw(T7, Address(T2, 0));
- __ b(&init_loop);
- __ delay_slot()->addiu(T2, T2, Immediate(kWordSize));
+ Label init_loop;
+ __ Bind(&init_loop);
+ __ sw(T7, Address(T2, 0));
+ __ addiu(T2, T2, Immediate(kWordSize));
+ __ BranchUnsignedLess(T2, T1, &init_loop);
+ }
+ __ b(done);
}
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698