Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Issue 447613002: Make Change implementation consistent with the server spec. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make Change implementation consistent with the server spec. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -523 lines) Patch
M pkg/analysis_server/lib/src/edit/fix.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/edit/fix_test.dart View 2 chunks +1 line, -67 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +7 lines, -35 lines 0 comments Download
M pkg/analysis_services/lib/constants.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_services/lib/correction/change.dart View 9 chunks +70 lines, -74 lines 0 comments Download
M pkg/analysis_services/lib/src/correction/assist.dart View 5 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_services/lib/src/correction/fix.dart View 9 chunks +19 lines, -19 lines 0 comments Download
M pkg/analysis_services/lib/src/correction/source_buffer.dart View 4 chunks +12 lines, -10 lines 0 comments Download
M pkg/analysis_services/test/correction/assist_test.dart View 8 chunks +26 lines, -17 lines 0 comments Download
M pkg/analysis_services/test/correction/change_test.dart View 7 chunks +113 lines, -263 lines 0 comments Download
M pkg/analysis_services/test/correction/fix_test.dart View 6 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 4 months ago (2014-08-05 21:21:41 UTC) #1
Brian Wilkerson
LGTM
6 years, 4 months ago (2014-08-05 21:24:28 UTC) #2
scheglov
6 years, 4 months ago (2014-08-05 21:39:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 38908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698