Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: pkg/analysis_services/lib/src/correction/source_buffer.dart

Issue 447613002: Make Change implementation consistent with the server spec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_services/lib/src/correction/source_buffer.dart
diff --git a/pkg/analysis_services/lib/src/correction/source_buffer.dart b/pkg/analysis_services/lib/src/correction/source_buffer.dart
index 48a030d3adf62bd57626637a94986f8de3ee9c71..c893865ccbd37284e79de7e3085695b73e329569 100644
--- a/pkg/analysis_services/lib/src/correction/source_buffer.dart
+++ b/pkg/analysis_services/lib/src/correction/source_buffer.dart
@@ -19,9 +19,9 @@ class SourceBuilder {
final int offset;
final StringBuffer _buffer = new StringBuffer();
- final List<LinkedPositionGroup> linkedPositionGroups = <LinkedPositionGroup>[
+ final List<LinkedEditGroup> linkedPositionGroups = <LinkedEditGroup>[
];
- LinkedPositionGroup _currentLinkedPositionGroup;
+ LinkedEditGroup _currentLinkedPositionGroup;
int _currentPositionStart;
SourceBuilder(this.file, this.offset);
@@ -30,12 +30,13 @@ class SourceBuilder {
int get length => _buffer.length;
- void addProposal(String proposal) {
- _currentLinkedPositionGroup.addProposal(proposal);
+ void addSuggestion(LinkedEditSuggestionKind kind, String value) {
+ var suggestion = new LinkedEditSuggestion(kind, value);
+ _currentLinkedPositionGroup.addSuggestion(suggestion);
}
- void addProposals(List<String> proposals) {
- proposals.forEach((proposal) => addProposal(proposal));
+ void addSuggestions(LinkedEditSuggestionKind kind, List<String> values) {
+ values.forEach((value) => addSuggestion(kind, value));
}
/**
@@ -60,14 +61,14 @@ class SourceBuilder {
*/
void startPosition(String groupId) {
assert(_currentLinkedPositionGroup == null);
- for (LinkedPositionGroup position in linkedPositionGroups) {
+ for (LinkedEditGroup position in linkedPositionGroups) {
if (position.id == groupId) {
_currentLinkedPositionGroup = position;
break;
}
}
if (_currentLinkedPositionGroup == null) {
- _currentLinkedPositionGroup = new LinkedPositionGroup(groupId);
+ _currentLinkedPositionGroup = new LinkedEditGroup(groupId);
linkedPositionGroups.add(_currentLinkedPositionGroup);
}
_currentPositionStart = _buffer.length;
@@ -82,7 +83,8 @@ class SourceBuilder {
void _addPosition() {
int start = offset + _currentPositionStart;
int end = offset + _buffer.length;
- Position position = new Position(file, start, end - start);
- _currentLinkedPositionGroup.addPosition(position);
+ int length = end - start;
+ Position position = new Position(file, start);
+ _currentLinkedPositionGroup.addPosition(position, length);
}
}
« no previous file with comments | « pkg/analysis_services/lib/src/correction/fix.dart ('k') | pkg/analysis_services/test/correction/assist_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698