Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 446983002: Change the type of Error.code from int to String. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the type of Error.code from int to String. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -48 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 10 chunks +22 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 10 chunks +13 lines, -13 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-06 18:40:03 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-06 18:41:48 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-06 18:44:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38940 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698