Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 443923002: Add a compile time error for non-static const fields (Closed)

Created:
6 years, 4 months ago by Johnni Winther
Modified:
6 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a compile time error for non-static const fields Based on https://codereview.chromium.org/339583004/ BUG=http://dartbug.com/11049 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=38924

Patch Set 1 #

Patch Set 2 : Add language test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A + tests/language/const_instance_field_test.dart View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
PTAL at the last patch.
6 years, 4 months ago (2014-08-06 10:17:04 UTC) #1
karlklose
LGTM.
6 years, 4 months ago (2014-08-06 10:19:57 UTC) #2
Johnni Winther
6 years, 4 months ago (2014-08-06 10:35:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698