Issue 443883002: Change void typed setters in html_dart2js not to return a value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 443883002: Change void typed setters in html_dart2js not to return a value. (Closed)

Created:
6 years, 4 months ago by karlklose

Modified:
6 years, 4 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Change void typed setters in html_dart2js not to return a value. Even though the return value of a setter is ignored, it must be checked against the declared return type in checked mode since setters are evaluated like normal functions (see Specification, 16.12). BUG= http://dartbug.com/20381 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38925

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
M	sdk/lib/_blink/dartium/_blink_dartium.dart	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+11 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

karlklose

The modifications to blink_dartium are not due to my changes but I am going to ...

6 years, 4 months ago (2014-08-06 09:40:38 UTC) #2

karlklose

6 years, 4 months ago (2014-08-06 10:48:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 38925 (presubmit successful).