sdk/lib/html/dart2js/html_dart2js.dart - Issue 443883002: Change void typed setters in html_dart2js not to return a value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 443883002: Change void typed setters in html_dart2js not to return a value. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change templates and regenerate files. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index fd51eca44198c28fc876369ea652452227759c0d..01a239a7277bbf688c538c985e7e3d84d70dd462 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -1934,9 +1934,11 @@ class CanvasRenderingContext2D extends CanvasRenderingContext {

@DomName('CanvasRenderingContext2D.lineDashOffset')

// TODO(14316): Firefox has this functionality with mozDashOffset, but it

// needs to be polyfilled.

- void set lineDashOffset(num value) => JS('void',

- 'typeof #.lineDashOffset != "undefined" ? #.lineDashOffset = # : '

- '#.webkitLineDashOffset = #', this, this, value, this, value);

+ void set lineDashOffset(num value) {

+ JS('void',

+ 'typeof #.lineDashOffset != "undefined" ? #.lineDashOffset = # : '

+ '#.webkitLineDashOffset = #', this, this, value, this, value);

+ }

@SupportedBrowser(SupportedBrowser.CHROME)

@SupportedBrowser(SupportedBrowser.SAFARI)

@@ -10309,7 +10311,9 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,

@DomName('Element.scrollLeft')

@DocsEditable()

- void set scrollLeft(int value) => JS("void", "#.scrollLeft = #", this, value.round());

+ void set scrollLeft(int value) {

+ JS("void", "#.scrollLeft = #", this, value.round());

+ }

@DomName('Element.scrollTop')

@DocsEditable()

@@ -10317,7 +10321,9 @@ abstract class Element extends Node implements GlobalEventHandlers, ParentNode,

@DomName('Element.scrollTop')

@DocsEditable()

- void set scrollTop(int value) => JS("void", "#.scrollTop = #", this, value.round());

+ void set scrollTop(int value) {

+ JS("void", "#.scrollTop = #", this, value.round());

+ }

@DomName('Element.scrollWidth')

@DocsEditable()