Add property to CssStyleDeclaration to detect if a CSS value is available.

This is the dart side edits to make this happen.

Fix for https://code.google.com/p/dart/issues/detail?id=19932

BUG=
R=leafp@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38996

[Emily Fortuna, 2014-08-05 22:14:14]

https://codereview.chromium.org/442523003/diff/60001/tools/dom/scripts/css_co...
File tools/dom/scripts/css_code_generator.py (right):

https://codereview.chromium.org/442523003/diff/60001/tools/dom/scripts/css_co...
tools/dom/scripts/css_code_generator.py:15: SOURCE_PATH = 'CSSPropertyNames.in'
I will remove this TODO and the commented out SOURCE_PATH once this CL:
https://codereview.chromium.org/444453006/ is in. (Terry says tomorrow)

[Leaf, 2014-08-05 23:52:53]

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
File sdk/lib/_blink/dartium/_blink_dartium.dart (left):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:2173: 
This will break if checked in - not a problem with your changes, but you'll need
to work around it.  This CL  https://codereview.chromium.org//395913002 seems to
have deleted this from the idl, but not updated blink (and doesn't work if blink
is regenerated).  This should get fixed soon, but in the meantime, you might
want to just hand add this back in before checking in.

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
File sdk/lib/_blink/dartium/_blink_dartium.dart (right):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:714: static
$__getter___Callback(mthis, name) native
"CSSStyleDeclaration___getter___Callback_RESOLVER_STRING_1_DOMString";
I may have lost track of the plot here - but I didn't think you were adding the
named getters in - I thought you were exposing query operators?

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:2924: static
$namedItem_Callback(mthis, name) native
"HTMLFormControlsCollection_namedItem_Callback_RESOLVER_STRING_1_DOMString";
Why is this showing up here - this doesn't seem related to your changes?

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
sdk/lib/html/dartium/html_dartium.dart:3419: +
So is this temporary then, pending the query operator?  This doesn't really do
what you want, right (per your comment in _supportsProperty above).

https://codereview.chromium.org/442523003/diff/60001/tools/dom/templates/html...
File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
(right):

https://codereview.chromium.org/442523003/diff/60001/tools/dom/templates/html...
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:66: $endif
Will this work in checked mode?  The getter returns the value, right?  Which
doesn't have type bool.  Or is the C++ code for the getter returning a bool? 
I'm a little confused here.

[Emily Fortuna, 2014-08-06 00:32:27]

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
File sdk/lib/_blink/dartium/_blink_dartium.dart (right):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:714: static
$__getter___Callback(mthis, name) native
"CSSStyleDeclaration___getter___Callback_RESOLVER_STRING_1_DOMString";
On 2014/08/05 23:52:52, leafp wrote:
> I may have lost track of the plot here - but I didn't think you were adding
the
> named getters in - I thought you were exposing query operators?

Query is part of the getters. That's how it's exposed, through the named
getters.

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/_blink/dartium/_...
sdk/lib/_blink/dartium/_blink_dartium.dart:2924: static
$namedItem_Callback(mthis, name) native
"HTMLFormControlsCollection_namedItem_Callback_RESOLVER_STRING_1_DOMString";
On 2014/08/05 23:52:52, leafp wrote:
> Why is this showing up here - this doesn't seem related to your changes?

It is related because these members also have union return types which were
previously getting omitted.

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
sdk/lib/html/dartium/html_dartium.dart:3419: +
On 2014/08/05 23:52:52, leafp wrote:
> So is this temporary then, pending the query operator?  This doesn't really do
> what you want, right (per your comment in _supportsProperty above).

As mentioned in one of my other comments, it's currently implemented to return
just boolean. It is one of three functions (see
https://codereview.chromium.org/400893007/diff/50001/Source/bindings/dart/scr...
the Dartium CL) and we're currently implementing just the one. As this getter is
private, only we will see it.

https://codereview.chromium.org/442523003/diff/60001/tools/dom/templates/html...
File tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate
(right):

https://codereview.chromium.org/442523003/diff/60001/tools/dom/templates/html...
tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate:66: $endif
On 2014/08/05 23:52:53, leafp wrote:
> Will this work in checked mode?  The getter returns the value, right?  Which
> doesn't have type bool.  Or is the C++ code for the getter returning a bool? 
> I'm a little confused here.

The getter returns type 'union" which is one of a few types. In the case we've
implemented on the C++ side, it only returns type "bool".

[Leaf, 2014-08-06 17:53:49]

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/442523003/diff/60001/sdk/lib/html/dartium/htm...
sdk/lib/html/dartium/html_dartium.dart:3419: +
Yes, but I don't understand why you're calling this __getter__ though.  In V8,
there are getter, setter, query, and enumerate methods.  As you say, this CL
only implements the query method (which is fine), but it seems to be calling it
"__getter__", which seems very confusing.  Or am I still somehow confused?  I
was expecting to see a __query__Callback(this, propertyName) here (or something
similar).

On 2014/08/06 00:32:27, Emily Fortuna wrote:
> On 2014/08/05 23:52:52, leafp wrote:
> > So is this temporary then, pending the query operator?  This doesn't really
do
> > what you want, right (per your comment in _supportsProperty above).
> 
> As mentioned in one of my other comments, it's currently implemented to return
> just boolean. It is one of three functions (see
>
https://codereview.chromium.org/400893007/diff/50001/Source/bindings/dart/scr...
> the Dartium CL) and we're currently implementing just the one. As this getter
is
> private, only we will see it.

https://codereview.chromium.org/442523003/diff/60001/tools/dom/scripts/system...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/442523003/diff/60001/tools/dom/scripts/system...
tools/dom/scripts/systemnative.py:384: return
"CSSStyleDeclaration___getter___Callback_RESOLVER_STRING_1_DOMString"
Is it possible to use the pre-existing dirty-hack (_cpp_resolver_string_map) for
this instead?

[Emily Fortuna, 2014-08-07 01:52:55]

ptal

[Leaf, 2014-08-07 16:17:11]

lgtm

[Emily Fortuna, 2014-08-07 17:09:47]

Committed patchset #3 manually as 38996 (presubmit successful).