Issue 395913002: Change in preparation of fixing issue 19500.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 395913002: Change in preparation of fixing issue 19500. (Closed)

Created:
6 years, 5 months ago by siva

Modified:
6 years, 5 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Change in preparation of fixing issue 19500. The bindings code will be returning ByteBuffer in dartium so we account for that in the FileReader return values. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=38342

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_FileReader.darttemplate	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

siva

6 years, 5 months ago (2014-07-17 19:40:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r38342 (presubmit successful).