Issue 44143002: Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instructio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 44143002: Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instructio… (Closed)

Created:
7 years, 1 month ago by ngeoffray

Modified:
7 years, 1 month ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instruction. By making the update an assignment, we were generating the wrong order of copies. Since the checked input of HTypeKnown may have a name, we need to make it a copy. Committed: https://code.google.com/p/dart/source/detail?r=29331

Patch Set 1 : #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -1 line)			Patch
M	pkg/pkg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/tracer.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	tests/language/issue12336_test.dart	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

7 years, 1 month ago (2013-10-27 19:29:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r29331 (presubmit successful).

Expand Messages | Collapse Messages