sdk/lib/_internal/compiler/implementation/ssa/tracer.dart - Issue 44143002: Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instructio…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

Issue 44143002: Fix issue 12336: there was a bug when updating phis at exit of a block with a HTypeKnown instructio… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (revision 29323)

+++ sdk/lib/_internal/compiler/implementation/ssa/tracer.dart (working copy)

@@ -263,6 +263,9 @@

String visitExit(HExit node) => "exit";

String visitFieldGet(HFieldGet node) {

+ if (node.isNullCheck) {

+ return 'null check on ${temporaryId(node.receiver)}';

+ }

String fieldName = node.element.name;

return 'field get ${temporaryId(node.receiver)}.$fieldName';

}