Issue 44033002: Update status file, and fix unit tests.

Issue 44033002: Update status file, and fix unit tests. (Closed)

Created:
7 years, 1 month ago by ngeoffray

Modified:
7 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update status file, and fix unit tests. Committed: https://code.google.com/p/dart/source/detail?r=29245

Patch Set 1 #

Total comments: 3

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -10 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/interceptor_test.dart	View	1 chunk	+1 line, -1 line	3 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Committed patchset #1 manually as r29245 (presubmit successful).

7 years, 1 month ago (2013-10-25 11:54:42 UTC) #2

floitsch

LGTM. https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interceptor_test.dart File tests/compiler/dart2js/interceptor_test.dart (right): https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interceptor_test.dart#newcode40 tests/compiler/dart2js/interceptor_test.dart:40: generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as$a$'))); I have to trust on this ...

7 years, 1 month ago (2013-10-25 11:57:02 UTC) #3

ngeoffray

https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interceptor_test.dart File tests/compiler/dart2js/interceptor_test.dart (right): https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interceptor_test.dart#newcode40 tests/compiler/dart2js/interceptor_test.dart:40: generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as$a$'))); On 2013/10/25 11:57:02, floitsch wrote: > I ...

7 years, 1 month ago (2013-10-25 11:58:03 UTC) #4

floitsch

7 years, 1 month ago (2013-10-25 12:20:39 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interc...
File tests/compiler/dart2js/interceptor_test.dart (right):

https://codereview.chromium.org/44033002/diff/1/tests/compiler/dart2js/interc...
tests/compiler/dart2js/interceptor_test.dart:40: generated.contains(new
RegExp(r'[$A-Z]+\.get\$length\$as\(a\)')));
On 2013/10/25 11:58:03, ngeoffray wrote:
> On 2013/10/25 11:57:02, floitsch wrote:
> > I have to trust on this one.
> > If you are not sure, please find another reviewer.
> 
> Because we instantiate the string class now, the interceptor is being called
> 'something$as'. The 's' at the end stands for String.

ok. makes sense.

Expand Messages | Collapse Messages