tests/compiler/dart2js/interceptor_test.dart - Issue 44033002: Update status file, and fix unit tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/compiler/dart2js/interceptor_test.dart

Issue 44033002: Update status file, and fix unit tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 import "package:expect/expect.dart";	5 import "package:expect/expect.dart";

6 import 'compiler_helper.dart';	6 import 'compiler_helper.dart';

7	7

8 const String TEST_ONE = r"""	8 const String TEST_ONE = r"""

9 foo(a) {	9 foo(a) {

10 var myVariableName = a.toString();	10 var myVariableName = a.toString();

(...skipping 19 matching lines...) Expand all Loading...
30 Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.toString\$0\(a\)')));	30 Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.toString\$0\(a\)')));

31 Expect.isTrue(generated.contains('myVariableName'));	31 Expect.isTrue(generated.contains('myVariableName'));

32	32

33 // Check that an intercepted getter that does not need to be	33 // Check that an intercepted getter that does not need to be

34 // intercepted, is turned into a regular getter call or field	34 // intercepted, is turned into a regular getter call or field

35 // access.	35 // access.

36 generated = compile(TEST_TWO, entry: 'foo');	36 generated = compile(TEST_TWO, entry: 'foo');

37 Expect.isFalse(generated.contains(r'a.get$length()'));	37 Expect.isFalse(generated.contains(r'a.get$length()'));

38 Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.A\$\(\)\.length')));	38 Expect.isTrue(generated.contains(new RegExp(r'[$A-Z]+\.A\$\(\)\.length')));

39 Expect.isTrue(	39 Expect.isTrue(

40 generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$a\(a\)')));	40 generated.contains(new RegExp(r'[$A-Z]+\.get\$length\$as\(a\)')));
	floitsch 2013/10/25 11:57:02 I have to trust on this one. If you are not sure, I have to trust on this one. If you are not sure, please find another reviewer. ngeoffray 2013/10/25 11:58:03 Because we instantiate the string class now, the i Show quoted text On 2013/10/25 11:57:02, floitsch wrote: > I have to trust on this one. > If you are not sure, please find another reviewer. Because we instantiate the string class now, the interceptor is being called 'something$as'. The 's' at the end stands for String. floitsch 2013/10/25 12:20:39 ok. makes sense. Show quoted text On 2013/10/25 11:58:03, ngeoffray wrote: > On 2013/10/25 11:57:02, floitsch wrote: > > I have to trust on this one. > > If you are not sure, please find another reviewer. > > Because we instantiate the string class now, the interceptor is being called > 'something$as'. The 's' at the end stands for String. ok. makes sense.
41 }	41 }

OLD	NEW