Issue 437383003: Simplify handling of pathnames in integration tests.

Issue 437383003: Simplify handling of pathnames in integration tests. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify handling of pathnames in integration tests. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=38890

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -39 lines)			Patch
M	pkg/analysis_server/test/integration/analysis_domain_int_test.dart	View	5 chunks	+12 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis_error_int_test.dart	View	1 chunk	+4 lines, -3 lines	2 comments	Download
M	pkg/analysis_server/test/integration/completion_domain_int_test.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/test/integration/server_domain_int_test.dart	View	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/437383003/diff/1/pkg/analysis_server/test/integration/analysis_error_int_test.dart File pkg/analysis_server/test/integration/analysis_error_int_test.dart (right): https://codereview.chromium.org/437383003/diff/1/pkg/analysis_server/test/integration/analysis_error_int_test.dart#newcode25 pkg/analysis_server/test/integration/analysis_error_int_test.dart:25: String filePath = pathname; I'm not sure what ...

6 years, 4 months ago (2014-08-04 23:26:51 UTC) #2

Paul Berry

Committed patchset #1 manually as r38890 (presubmit successful).

6 years, 4 months ago (2014-08-05 03:30:15 UTC) #3

Paul Berry

6 years, 4 months ago (2014-08-05 03:48:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/437383003/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/analysis_error_int_test.dart (right):

https://codereview.chromium.org/437383003/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/analysis_error_int_test.dart:25: String
filePath = pathname;
On 2014/08/04 23:26:51, Brian Wilkerson wrote:
> I'm not sure what the value of defining a local variable is, but given that it
> was already there I won't comment on it.

Oops, not sure what I was thinking there.  Fixed.

Expand Messages | Collapse Messages