Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 436423002: Remove 'analysis.updateSdks' from server. (Closed)

Created:
6 years, 4 months ago by scheglov
Modified:
6 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +0 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 4 months ago (2014-08-04 23:40:14 UTC) #1
jwren
On 2014/08/04 23:40:14, scheglov wrote: LGTM
6 years, 4 months ago (2014-08-04 23:41:10 UTC) #2
scheglov
Committed patchset #1 manually as 38887 (presubmit successful).
6 years, 4 months ago (2014-08-04 23:43:00 UTC) #3
Brian Wilkerson
6 years, 4 months ago (2014-08-05 00:23:22 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698