Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 436423002: Remove 'analysis.updateSdks' from server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/constants.dart ('k') | pkg/analysis_server/test/domain_analysis_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index c67ad63fad237719e6af11740604d162450e9604..ed21d0af1f60e16b3813063d9b44463065c64897 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -108,8 +108,6 @@ class AnalysisDomainHandler implements RequestHandler {
return updateContent(request);
} else if (requestName == ANALYSIS_UPDATE_OPTIONS) {
return updateOptions(request);
- } else if (requestName == ANALYSIS_UPDATE_SDKS) {
- return updateSdks(request);
}
} on RequestFailure catch (exception) {
return exception.response;
@@ -242,23 +240,6 @@ class AnalysisDomainHandler implements RequestHandler {
server.updateOptions(updaters);
return new Response(request.id);
}
-
- /**
- * Implement the 'analysis.updateSdks' request.
- */
- Response updateSdks(Request request) {
- // added
- RequestDatum addedDatum = request.getRequiredParameter(ADDED);
- List<String> added = addedDatum.asStringList();
- // removed
- RequestDatum removedDatum = request.getRequiredParameter(REMOVED);
- List<String> removed = removedDatum.asStringList();
- // default
- RequestDatum defaultDatum = request.getRequiredParameter(DEFAULT);
- String defaultSdk = defaultDatum.asString();
- // TODO(scheglov) implement
- return null;
- }
}
« no previous file with comments | « pkg/analysis_server/lib/src/constants.dart ('k') | pkg/analysis_server/test/domain_analysis_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698