Issue 436263002: incremental progress reworking code completion manager / computers

Issue 436263002: incremental progress reworking code completion manager / computers (Closed)

Created:
6 years, 4 months ago by danrubel

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

incremental progress reworking code completion manager / computers BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38871

Patch Set 2 : address comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -70 lines)			Patch
M	pkg/analysis_server/lib/src/domain_completion.dart	View		3 chunks	+12 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	1	3 chunks	+4 lines, -8 lines	0 comments	Download
M	pkg/analysis_services/lib/completion/completion_computer.dart	View	1	4 chunks	+53 lines, -37 lines	0 comments	Download
M	pkg/analysis_services/test/completion/completion_computer_test.dart	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/436263002/diff/1/pkg/analysis_server/test/domain_completion_test.dart File pkg/analysis_server/test/domain_completion_test.dart (right): https://codereview.chromium.org/436263002/diff/1/pkg/analysis_server/test/domain_completion_test.dart#newcode85 pkg/analysis_server/test/domain_completion_test.dart:85: return pumpEventQueue(); Why do we need this change? ...

6 years, 4 months ago (2014-08-04 17:00:31 UTC) #2

danrubel

https://codereview.chromium.org/436263002/diff/1/pkg/analysis_server/test/domain_completion_test.dart File pkg/analysis_server/test/domain_completion_test.dart (right): https://codereview.chromium.org/436263002/diff/1/pkg/analysis_server/test/domain_completion_test.dart#newcode85 pkg/analysis_server/test/domain_completion_test.dart:85: return pumpEventQueue(); On 2014/08/04 17:00:30, scheglov wrote: > Why ...

6 years, 4 months ago (2014-08-04 17:33:13 UTC) #3

danrubel

6 years, 4 months ago (2014-08-04 17:37:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 38871 (presubmit successful).

Expand Messages | Collapse Messages