Issue 435603005: Add --dart2js-options flag to test command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435603005: Add --dart2js-options flag to test command (Closed)

Created:
6 years, 4 months ago by sra1

Modified:
6 years, 4 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add --dart2js-options flag to test command Example: tools/test.py ... --dart2js-options='--dump-info' ... will run the dart2js compilation step with --dump-info R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38836

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -11 lines)			Patch
M	tools/testing/dart/compiler_configuration.dart	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 chunk	+14 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #1 manually as 38836 (presubmit successful).

6 years, 4 months ago (2014-08-01 17:05:45 UTC) #3

Ty Overby (Google)

On 2014/08/01 17:05:45, sra1 wrote: > Committed patchset #1 manually as 38836 (presubmit successful). Does ...

6 years, 4 months ago (2014-08-01 17:51:41 UTC) #4

sra1

6 years, 4 months ago (2014-08-01 17:58:40 UTC) #5

Message was sent while issue was closed.

On 2014/08/01 17:51:41, Ty Overby (Google) wrote:
> On 2014/08/01 17:05:45, sra1 wrote:
> > Committed patchset #1 manually as 38836 (presubmit successful).
> 
> Does this add --dump-info to any of the tests in the current build matrix?

No.  It just allows it to be set locally with --dart2js-options='--dump-info'

We still need to add it to the build matrix.

Expand Messages | Collapse Messages