Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 435603005: Add --dart2js-options flag to test command (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 58a4c54559a4cfca885e49af32155e814026698d..3407c67f1eb7c5a9944e7b5cd6d7a760887eb68e 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -73,7 +73,9 @@ abstract class CompilerConfiguration {
case 'dart2js':
return new Dart2jsCompilerConfiguration(
isDebug: isDebug, isChecked: isChecked,
- isHostChecked: isHostChecked, useSdk: useSdk, isCsp: isCsp);
+ isHostChecked: isHostChecked, useSdk: useSdk, isCsp: isCsp,
+ extraDart2jsOptions:
+ TestUtils.getExtraOptions(configuration, 'dart2js_options'));
case 'dart2dart':
return new Dart2dartCompilerConfiguration(
isDebug: isDebug, isChecked: isChecked,
@@ -222,13 +224,15 @@ class Dart2xCompilerConfiguration extends CompilerConfiguration {
/// Configuration for dart2js compiler.
class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
final bool isCsp;
+ final List<String> extraDart2jsOptions;
Dart2jsCompilerConfiguration({
bool isDebug,
bool isChecked,
bool isHostChecked,
bool useSdk,
- bool this.isCsp})
+ bool this.isCsp,
+ this.extraDart2jsOptions})
: super(
'dart2js',
isDebug: isDebug, isChecked: isChecked,
@@ -254,7 +258,7 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
'$tempDir/out.js',
buildDir,
CommandBuilder.instance,
- arguments,
+ []..addAll(arguments)..addAll(extraDart2jsOptions),
environmentOverrides)],
'$tempDir/out.js',
'application/javascript');
« no previous file with comments | « no previous file | tools/testing/dart/test_options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698