Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 434763002: Add VMService GC events (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
turnidge, Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a new event family for GC-related events, and generate an event after each garbage collection with basic stats. One reason for this is to provide a structured alternative to the ad hoc logging format of --verbose_gc, and to move some functionality currently provided by standalone one-off scripts into the observatory. Add first unit test for events. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39014

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5243 lines, -5485 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 575 chunks +2601 lines, -2788 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 580 chunks +2519 lines, -2695 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download
A runtime/bin/vmservice/observatory/test/gc_script.dart View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/test/gc_test.dart View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/heap.h View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 1 2 3 3 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/service.h View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/service/constants.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
This CL doesn't include any Observatory UI for these events (while developing I've relied on ...
6 years, 4 months ago (2014-08-05 05:00:27 UTC) #1
koda
Added unit test (first unit test for async events).
6 years, 4 months ago (2014-08-06 23:50:02 UTC) #2
Cutch
lgtm
6 years, 4 months ago (2014-08-07 14:48:08 UTC) #3
koda
6 years, 4 months ago (2014-08-07 23:52:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r39014 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698