Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 434763002: Add VMService GC events (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart
===================================================================
--- runtime/bin/vmservice/observatory/lib/src/service/object.dart (revision 39000)
+++ runtime/bin/vmservice/observatory/lib/src/service/object.dart (working copy)
@@ -270,8 +270,14 @@
// Extract the owning isolate from the event itself.
String owningIsolateId = map['isolate']['id'];
_getIsolate(owningIsolateId).then((owningIsolate) {
- var event = new ServiceObject._fromMap(owningIsolate, map);
- events.add(event);
+ if (owningIsolate == null) {
+ // TODO(koda): Do we care about GC events in VM isolate?
+ Logger.root.severe(
+ 'Ignoring event with unknown isolate id: $owningIsolateId');
+ } else {
+ var event = new ServiceObject._fromMap(owningIsolate, map);
+ events.add(event);
+ }
});
}

Powered by Google App Engine
This is Rietveld 408576698