Issue 434533002: Make any exception in the operations loop fatal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434533002: Make any exception in the operations loop fatal. (Closed)

Created:
6 years, 4 months ago by scheglov

Modified:
6 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make any exception in the operations loop fatal. Note, that with the latest analyzer snapshot the NPE we saw does not leak anymore, so this code does not work. But the result is not much better - context continues analyzing the same file again and again. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38785

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

scheglov

Committed patchset #1 manually as r38785 (presubmit successful).

6 years, 4 months ago (2014-07-31 15:57:21 UTC) #3

Message was sent while issue was closed.

lgtm