Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 434533002: Make any exception in the operations loop fatal. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 16f00f98389c960fc554f0cd31c58602b67f1201..279884ab50c37b56f44d56e190fb453b4e90cc5d 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -403,6 +403,7 @@ class AnalysisServer {
new CaughtException(exception, stackTrace));
}
_sendServerErrorNotification(exception, stackTrace);
+ shutdown();
} finally {
if (!operationQueue.isEmpty) {
_schedulePerformOperation();
@@ -740,7 +741,7 @@ class AnalysisServer {
}
/**
- * Sends a non-fatal `server.error` notification.
+ * Sends a fatal `server.error` notification.
*/
void _sendServerErrorNotification(exception, stackTrace) {
// prepare exception.toString()
@@ -759,7 +760,7 @@ class AnalysisServer {
}
// send the notification
Notification notification = new Notification(SERVER_ERROR);
- notification.setParameter(FATAL, false);
+ notification.setParameter(FATAL, true);
notification.setParameter(MESSAGE, exceptionString);
notification.setParameter(STACK_TRACE, stackTraceString);
channel.sendNotification(notification);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698