Issue 432913002: Don't allow pre-release versions of the max in "<" constraints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 432913002: Don't allow pre-release versions of the max in "<" constraints. (Closed)

Created:
6 years, 4 months ago by Bob Nystrom

Modified:
6 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, Alan Knight

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't allow pre-release versions of the max in "<" constraints. RELNOTE=Pub will exclude pre-release versions of the upper bound in "<" constraints. This matches the behavior of semver in other package managers. BUG=https://code.google.com/p/dart/issues/detail?id=20302 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38806

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -13 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/version.dart	View	1 chunk	+21 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/cache/add/all_adds_all_matching_versions_test.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/version_solver_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/test/version_test.dart	View	4 chunks	+30 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

6 years, 4 months ago (2014-07-31 22:25:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38806 (presubmit successful).

Expand Messages | Collapse Messages