Don't allow pre-release versions of the max in "<" constraints.

sdk/lib/_internal/pub/test/version_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library version_test;
 
 import 'package:unittest/unittest.dart';
 import 'test_pub.dart';
 import '../lib/src/version.dart';
 
@@ skipping 235 matching lines @@
         expect(range.includeMax, isFalse);
       });
 
       test('throws if min > max', () {
         throwsIllegalArg(() => new VersionRange(min: v124, max: v123));
       });
     });
 
     group('allows()', () {
       test('version must be greater than min', () {
-        var range = new VersionRange(min: v123, max: v234);
+        var range = new VersionRange(min: v123);
 
         expect(range.allows(new Version.parse('1.2.2')), isFalse);
         expect(range.allows(new Version.parse('1.2.3')), isFalse);
         expect(range.allows(new Version.parse('1.3.3')), isTrue);
         expect(range.allows(new Version.parse('2.3.3')), isTrue);
       });
 
       test('version must be min or greater if includeMin', () {
-        var range = new VersionRange(min: v123, max: v234, includeMin: true);
+        var range = new VersionRange(min: v123, includeMin: true);
 
         expect(range.allows(new Version.parse('1.2.2')), isFalse);
         expect(range.allows(new Version.parse('1.2.3')), isTrue);
         expect(range.allows(new Version.parse('1.3.3')), isTrue);
         expect(range.allows(new Version.parse('2.3.3')), isTrue);
       });
 
+      test('pre-release versions of inclusive min are excluded', () {
+        var range = new VersionRange(min: v123, includeMin: true);
+
+        expect(range.allows(new Version.parse('1.2.3-dev')), isFalse);
+        expect(range.allows(new Version.parse('1.2.4-dev')), isTrue);
+      });
+
       test('version must be less than max', () {
-        var range = new VersionRange(min: v123, max: v234);
+        var range = new VersionRange(max: v234);
 
         expect(range.allows(new Version.parse('2.3.3')), isTrue);
         expect(range.allows(new Version.parse('2.3.4')), isFalse);
         expect(range.allows(new Version.parse('2.4.3')), isFalse);
       });
 
+      test('pre-release versions of non-pre-release max are excluded', () {
+        var range = new VersionRange(max: v234);
+
+        expect(range.allows(new Version.parse('2.3.3')), isTrue);
+        expect(range.allows(new Version.parse('2.3.4-dev')), isFalse);
+        expect(range.allows(new Version.parse('2.3.4')), isFalse);
+      });
+
+      test('pre-release versions of pre-release max are included', () {
+        var range = new VersionRange(max: new Version.parse('2.3.4-dev.2'));
+
+        expect(range.allows(new Version.parse('2.3.4-dev.1')), isTrue);
+        expect(range.allows(new Version.parse('2.3.4-dev.2')), isFalse);
+        expect(range.allows(new Version.parse('2.3.4-dev.3')), isFalse);
+      });
+
       test('version must be max or less if includeMax', () {
         var range = new VersionRange(min: v123, max: v234, includeMax: true);
 
         expect(range.allows(new Version.parse('2.3.3')), isTrue);
         expect(range.allows(new Version.parse('2.3.4')), isTrue);
         expect(range.allows(new Version.parse('2.4.3')), isFalse);
+
+        // Pre-releases of the max are allowed.
+        expect(range.allows(new Version.parse('2.3.4-dev')), isTrue);
       });
 
       test('has no min if one was not set', () {
         var range = new VersionRange(max: v123);
 
         expect(range.allows(new Version.parse('0.0.0')), isTrue);
         expect(range.allows(new Version.parse('1.2.3')), isFalse);
       });
 
       test('has no max if one was not set', () {
@@ skipping 112 matching lines @@
             new Version.parse('1.2.3+foo'),
             new Version.parse('1.2.4')]));
         expect(new VersionConstraint.parse('>=1.2.3'), doesNotAllow([
             new Version.parse('1.2.1'),
             new Version.parse('1.2.3-build')]));
       });
 
       test('parses a "<" maximum version', () {
         expect(new VersionConstraint.parse('<1.2.3'), allows([
             new Version.parse('1.2.1'),
-            new Version.parse('1.2.3-build')]));
+            new Version.parse('1.2.2+foo')]));
         expect(new VersionConstraint.parse('<1.2.3'), doesNotAllow([
             new Version.parse('1.2.3'),
             new Version.parse('1.2.3+foo'),
             new Version.parse('1.2.4')]));
       });
 
       test('parses a "<=" maximum version', () {
         expect(new VersionConstraint.parse('<=1.2.3'), allows([
             new Version.parse('1.2.1'),
             new Version.parse('1.2.3-build'),
@@ skipping 93 matching lines @@
 
 Matcher allows(List<Version> versions) =>
     new VersionConstraintMatcher(versions, true);
 
 Matcher doesNotAllow(List<Version> versions) =>
     new VersionConstraintMatcher(versions, false);
 
 throwsIllegalArg(function) {
   expect(function, throwsA((e) => e is ArgumentError));
 }