Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 432533002: Run template binding callbacks in the correct zone (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 4 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run template binding callbacks in the correct zone R=jakemac@google.com Committed: https://code.google.com/p/dart/source/detail?r=38751

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M pkg/template_binding/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/template_binding/lib/src/node.dart View 1 2 chunks +12 lines, -6 lines 0 comments Download
M pkg/template_binding/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-07-30 20:48:43 UTC) #1
jakemac
lgtm Might want to update polymers pubspec as well to accept this as the minimum ...
6 years, 4 months ago (2014-07-30 21:05:07 UTC) #2
Siggi Cherem (dart-lang)
thanks! as we spoke in person - we can leave it as it is, since ...
6 years, 4 months ago (2014-07-30 21:21:47 UTC) #3
Siggi Cherem (dart-lang)
6 years, 4 months ago (2014-07-30 21:22:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698