Run template binding callbacks in the correct zone

pkg/template_binding/lib/src/node.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of template_binding;
 
 /** Extensions to the [Node] API. */
 class NodeBindExtension {
   final Node _node;
   final JsObject _js;
@@ skipping 119 matching lines @@
   // For performance, unwrap the Dart bindable if we find one.
   // Note: in the unlikely event some code messes with our __dartBindable
   // property we can simply fallback to a _JsBindable wrapper.
   return b is Bindable ? b : new _JsBindable(obj);
 }
 
 class _JsBindable extends Bindable {
   final JsObject _js;
   _JsBindable(JsObject obj) : _js = obj;
 
-  open(callback) => _js.callMethod('open', [callback]);
+  open(callback) => _js.callMethod('open',
+      [Zone.current.bindUnaryCallback(callback)]);
 
   close() => _js.callMethod('close');
 
   get value => _js.callMethod('discardChanges');
 
   set value(newValue) {
     _js.callMethod('setValue', [newValue]);
   }
 
   deliver() => _js.callMethod('deliver');
 }
 
 /// Given a [bindable], create a JS object proxy for it.
 /// This is the inverse of [jsObjectToBindable].
 JsObject bindableToJsObject(Bindable bindable) {
   if (bindable is _JsBindable) return bindable._js;
 
+  var zone = Zone.current;
+  inZone(f) => zone.bindCallback(f);
+  inZone1(f) => zone.bindUnaryCallback(f);

[jakemac, 2014/07/30 21:05:06]

might want to rename inZoneUnary, usually you don't see numbers in names

[Siggi Cherem (dart-lang), 2014/07/30 21:21:47]

Done.

+
   return new JsObject.jsify({
-    'open': (callback) => bindable.open((x) => callback.apply([x])),
-    'close': () => bindable.close(),
-    'discardChanges': () => bindable.value,
-    'setValue': (x) => bindable.value = x,
+    'open': inZone1((callback) => bindable.open((x) => callback.apply([x]))),
+    'close': inZone(() => bindable.close()),
+    'discardChanges': inZone(() => bindable.value),
+    'setValue': inZone1((x) => bindable.value = x),
     // NOTE: this is not used by Node.bind, but it's used by Polymer:
     // https://github.com/Polymer/polymer-dev/blob/ba2b68fe5a5721f60b5994135f3270e63588809a/src/declaration/properties.js#L130
     // Technically this works because 'deliver' is on PathObserver and
     // CompoundObserver. But ideally Polymer-JS would not assume that.
-    'deliver': () => bindable.deliver(),
+    'deliver': inZone(() => bindable.deliver()),
     // Save this so we can return it from [jsObjectToBindable]
     '__dartBindable': bindable
   });
 }
 
 /** Information about the instantiated template. */
 class TemplateInstance {
   // TODO(rafaelw): firstNode & lastNode should be read-synchronous
   // in cases where script has modified the template instance boundary.
 
   /** The first node of this template instantiation. */
   Node get firstNode => _firstNode;
 
   /**
    * The last node of this template instantiation.
    * This could be identical to [firstNode] if the template only expanded to a
    * single node.
    */
   Node get lastNode => _lastNode;
 
   /** The model used to instantiate the template. */
   final model;
 
   Node _firstNode, _lastNode;
 
   TemplateInstance(this.model);
 }