Issue 430973002: Only support the new source_span spans in barback.

Issue 430973002: Only support the new source_span spans in barback. (Closed)

Created:
6 years, 4 months ago by nweiz

Modified:
6 years, 4 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only support the new source_span spans in barback. This releases barback 0.15.0, code_transformers 0.2.0+1, observe 0.11.0+2, polymer 0.12.0+3, and smoke 0.2.0+3. BUG=19930 R=blois@google.com, rnystrom@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38762

Patch Set 2 : Changelog entries #

Total comments: 8

Patch Set 3 : Code review changes #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -86 lines)			Patch
M	pkg/barback/CHANGELOG.md	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/package_graph.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/barback/lib/src/log.dart	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
D	pkg/barback/lib/src/span_wrapper.dart	View		1 chunk	+0 lines, -45 lines	0 comments	Download
M	pkg/barback/lib/src/transformer/transform_logger.dart	View		6 chunks	+9 lines, -19 lines	0 comments	Download
M	pkg/barback/pubspec.yaml	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/code_transformers/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/observe/CHANGELOG.md	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/observe/pubspec.yaml	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/CHANGELOG.md	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/polymer/pubspec.yaml	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/smoke/CHANGELOG.md	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/smoke/pubspec.yaml	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/log.dart	View		3 chunks	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

nweiz

Bob for pub/barback, Pete and Siggi for miscellaneous pubspecs.

6 years, 4 months ago (2014-07-30 21:45:39 UTC) #1

Bob Nystrom

Aside from comments below, pub/barback changes LGTM. https://codereview.chromium.org/430973002/diff/1/pkg/barback/lib/src/log.dart File pkg/barback/lib/src/log.dart (left): https://codereview.chromium.org/430973002/diff/1/pkg/barback/lib/src/log.dart#oldcode8 pkg/barback/lib/src/log.dart:8: Shouldn't this ...

6 years, 4 months ago (2014-07-30 21:51:49 UTC) #2

Siggi Cherem (dart-lang)

https://codereview.chromium.org/430973002/diff/20001/pkg/polymer/CHANGELOG.md File pkg/polymer/CHANGELOG.md (right): https://codereview.chromium.org/430973002/diff/20001/pkg/polymer/CHANGELOG.md#newcode7 pkg/polymer/CHANGELOG.md:7: #### Pub version 0.12.0+3 do you mean +2? https://codereview.chromium.org/430973002/diff/20001/pkg/polymer/CHANGELOG.md#newcode10 ...

6 years, 4 months ago (2014-07-30 22:28:58 UTC) #3

nweiz

https://codereview.chromium.org/430973002/diff/1/pkg/barback/lib/src/log.dart File pkg/barback/lib/src/log.dart (left): https://codereview.chromium.org/430973002/diff/1/pkg/barback/lib/src/log.dart#oldcode8 pkg/barback/lib/src/log.dart:8: On 2014/07/30 21:51:49, Bob Nystrom wrote: > Shouldn't this ...

6 years, 4 months ago (2014-07-30 23:21:12 UTC) #5

nweiz

6 years, 4 months ago (2014-07-30 23:38:34 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r38762 (presubmit successful).

Expand Messages | Collapse Messages