Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: pkg/barback/lib/src/graph/package_graph.dart

Issue 430973002: Only support the new source_span spans in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/lib/src/log.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library barback.graph.package_graph; 5 library barback.graph.package_graph;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection'; 8 import 'dart:collection';
9 9
10 import '../asset/asset_id.dart'; 10 import '../asset/asset_id.dart';
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 } 201 }
202 202
203 if (_logController.hasListener) { 203 if (_logController.hasListener) {
204 _logController.add(entry); 204 _logController.add(entry);
205 } else if (entry.level != LogLevel.FINE) { 205 } else if (entry.level != LogLevel.FINE) {
206 // No listeners, so just print entry. 206 // No listeners, so just print entry.
207 var buffer = new StringBuffer(); 207 var buffer = new StringBuffer();
208 buffer.write("[${entry.level} ${entry.transform}] "); 208 buffer.write("[${entry.level} ${entry.transform}] ");
209 209
210 if (entry.span != null) { 210 if (entry.span != null) {
211 buffer.write(entry.span.getLocationMessage(entry.message)); 211 buffer.write(entry.span.message(entry.message));
212 } else { 212 } else {
213 buffer.write(entry.message); 213 buffer.write(entry.message);
214 } 214 }
215 215
216 print(buffer); 216 print(buffer);
217 } 217 }
218 } 218 }
219 219
220 /// If [this] is done processing, schedule a [BuildResult] to be emitted on 220 /// If [this] is done processing, schedule a [BuildResult] to be emitted on
221 /// [results]. 221 /// [results].
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 completer.completeError(error, stackTrace); 253 completer.completeError(error, stackTrace);
254 }); 254 });
255 }, onError: (error, stackTrace) { 255 }, onError: (error, stackTrace) {
256 _lastUnexpectedError = error; 256 _lastUnexpectedError = error;
257 _lastUnexpectedErrorTrace = stackTrace; 257 _lastUnexpectedErrorTrace = stackTrace;
258 _resultsController.addError(error, stackTrace); 258 _resultsController.addError(error, stackTrace);
259 }); 259 });
260 return completer.future; 260 return completer.future;
261 } 261 }
262 } 262 }
OLDNEW
« no previous file with comments | « pkg/barback/CHANGELOG.md ('k') | pkg/barback/lib/src/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698