Issue 20240. Use a FileManager that manages its own temporary directory.

Issue 20240. Use a FileManager that manages its own temporary directory.

So, we can have more than one index and server running.
And we know when it is time to delete or recreate this temporary directory.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20240

Committed: https://code.google.com/p/dart/source/detail?r=38652

[Paul Berry, 2014-07-28 21:26:04]

lgtm

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/lib/sr...
File
pkg/analysis_services/lib/src/index/store/temporary_folder_file_manager.dart
(right):

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/index/store/temporary_folder_file_manager.dart:46:
return null;
To be consistent with the error semantics below, this should be

  return new Future.value(null);

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/test/i...
File
pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
(right):

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/test/i...
pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart:52:
return fileManager.read(name);
Reading a file that does not exist should produce null, right?  So I think we
need to do something like:

return fileManager.read(name).then((result) {
  expect(result, isNull);
});

[scheglov, 2014-07-28 22:13:55]

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/lib/sr...
File
pkg/analysis_services/lib/src/index/store/temporary_folder_file_manager.dart
(right):

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/index/store/temporary_folder_file_manager.dart:46:
return null;
On 2014/07/28 21:26:03, Paul Berry wrote:
> To be consistent with the error semantics below, this should be
> 
>   return new Future.value(null);

Done.

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/test/i...
File
pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
(right):

https://codereview.chromium.org/426773002/diff/1/pkg/analysis_services/test/i...
pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart:52:
return fileManager.read(name);
On 2014/07/28 21:26:04, Paul Berry wrote:
> Reading a file that does not exist should produce null, right?  So I think we
> need to do something like:
> 
> return fileManager.read(name).then((result) {
>   expect(result, isNull);
> });

Done.

[scheglov, 2014-07-28 22:14:05]

Committed patchset #1 manually as r38652 (presubmit successful).