Issue 20240. Use a FileManager that manages its own temporary directory.

pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart

Index: pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
diff --git a/pkg/analysis_services/test/index/store/separate_file_manager_test.dart b/pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
similarity index 74%
rename from pkg/analysis_services/test/index/store/separate_file_manager_test.dart
rename to pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
index 223fe2c463242fa4174818918e390c75f8868d22..d54a37a50dfca911d61269e9acb7e9d915cf4dc4 100644
--- a/pkg/analysis_services/test/index/store/separate_file_manager_test.dart
+++ b/pkg/analysis_services/test/index/store/temporary_folder_file_manager_test.dart
@@ -2,11 +2,11 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library test.services.src.index.store.separate_file_mananer;
+library test.services.src.index.store.temporary_folder_file_mananer;
 
 import 'dart:io';
 
-import 'package:analysis_services/src/index/store/separate_file_manager.dart';
+import 'package:analysis_services/src/index/store/temporary_folder_file_manager.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:path/path.dart';
 import 'package:unittest/unittest.dart';
@@ -20,16 +20,14 @@ main() {
 
 @ReflectiveTestCase()
 class _SeparateFileManagerTest {
-  Directory tempDir;
-  SeparateFileManager fileManager;
+  TemporaryFolderFileManager fileManager;
 
   void setUp() {
-    tempDir = Directory.systemTemp.createTempSync('AnalysisServer_index');
-    fileManager = new SeparateFileManager(tempDir);
+    fileManager = new TemporaryFolderFileManager();
   }
 
   void tearDown() {
-    tempDir.delete(recursive: true);
+    fileManager.clear();
   }
 
   test_clear() {
@@ -49,6 +47,11 @@ class _SeparateFileManagerTest {
     fileManager.delete(name);
   }
 
+  test_read_doesNotExist() {
+    String name = "42.index";
+    return fileManager.read(name);

[Paul Berry, 2014/07/28 21:26:04]

Reading a file that does not exist should produce null, right?  So I think we
need to do something like:

return fileManager.read(name).then((result) {
  expect(result, isNull);
});

[scheglov, 2014/07/28 22:13:55]

Done.

+  }
+
   test_outputInput() {
     String name = "42.index";
     // create the file
@@ -69,6 +72,10 @@ class _SeparateFileManagerTest {
   }
 
   bool _existsSync(String name) {
-    return new File(join(tempDir.path, name)).existsSync();
+    Directory directory = fileManager.test_directory;
+    if (directory == null) {
+      return false;
+    }
+    return new File(join(directory.path, name)).existsSync();
   }
 }