Ensure that unmangled private names are unique.

Ensure that unmangled private names are unique.

BUG= http://dartbug.com/19177
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38721

[herhut, 2014-07-29 13:58:04]

This patch changes the reflection data annotations such that unmangled private
names are prefixed with a library name if they are not unique (i.e., the first
library where a private name occurs gets no prefix, all others are prefixed).
This is required as we use the unmangled names as symbols instead of proper
private Symbols with library information at runtime.

[floitsch, 2014-07-29 14:22:39]

LGTM.

https://codereview.chromium.org/425023002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/425023002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:373: return
'_$libraryName\$$nameString';
Is the libraryName the unminified name of the library? If yes, should we minify
it in minified mode?

[herhut, 2014-07-29 14:31:55]

https://codereview.chromium.org/425023002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/425023002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:373: return
'_$libraryName\$$nameString';
On 2014/07/29 14:22:39, floitsch wrote:
> Is the libraryName the unminified name of the library? If yes, should we
minify
> it in minified mode?

It is the minified name. However, we do not minify the [nameString] part, as
otherwise error messages would become somewhat meaningless. One could say the
same about the [libraryName] part but I think it is less severe there and we
currently do not report library names in most cases anyway.

[herhut, 2014-07-30 07:26:32]

Committed patchset #1 manually as r38721 (presubmit successful).