Issue 424693002: Remove new check that crashes on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 424693002: Remove new check that crashes on android. (Closed)

Created:
6 years, 4 months ago by Bill Hesse

Modified:
6 years, 4 months ago

Reviewers:
ricow1, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva, zra

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove new check that crashes on android. Check was added in r38499 BUG=dartbug.com/20181 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38603

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	runtime/vm/snapshot.cc	View		1 chunk	+0 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

This new check, added in https://codereview.chromium.org//415513002, fails on Android content_shell, because snapshot->length_ causes a segfault ...

6 years, 4 months ago (2014-07-28 09:05:09 UTC) #1

Bill Hesse

Committed patchset #1 manually as r38603 (presubmit successful).

6 years, 4 months ago (2014-07-28 09:16:01 UTC) #3

Ivan Posva

6 years, 4 months ago (2014-07-28 16:54:38 UTC) #4

Message was sent while issue was closed.

Thanks,
-Ivan

https://codereview.chromium.org/424693002/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (left):

https://codereview.chromium.org/424693002/diff/1/runtime/vm/snapshot.cc#oldco...
runtime/vm/snapshot.cc:141: if ((snapshot->length_ < 0) || (snapshot->length_ >
kIntptrMax)) {
This test is essential. I commented on the bug already, but you really need to
figure out why accessing the length on Android is causing you to crash.

Expand Messages | Collapse Messages