Issue 424543004: incremental progress aligning code completion api to spec

Issue 424543004: incremental progress aligning code completion api to spec (Closed)

Created:
6 years, 4 months ago by danrubel

Modified:
6 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

incremental progress aligning code completion api to spec BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38835

Patch Set 2 : address comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -92 lines)			Patch
M	pkg/analysis_server/lib/src/domain_completion.dart	View	1	4 chunks	+18 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View		5 chunks	+27 lines, -7 lines	0 comments	Download
M	pkg/analysis_services/lib/completion/completion_computer.dart	View	1	2 chunks	+86 lines, -7 lines	0 comments	Download
M	pkg/analysis_services/lib/completion/completion_suggestion.dart	View		7 chunks	+57 lines, -58 lines	0 comments	Download
M	pkg/analysis_services/lib/constants.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_services/test/completion/completion_computer_test.dart	View	1	2 chunks	+35 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM w/c about Source https://codereview.chromium.org/424543004/diff/1/pkg/analysis_server/lib/src/domain_completion.dart File pkg/analysis_server/lib/src/domain_completion.dart (right): https://codereview.chromium.org/424543004/diff/1/pkg/analysis_server/lib/src/domain_completion.dart#newcode58 pkg/analysis_server/lib/src/domain_completion.dart:58: Source source = new FileBasedSource.con1(new ...

6 years, 4 months ago (2014-07-31 22:28:47 UTC) #2

danrubel

Committed patchset #2 manually as 38835 (presubmit successful).

6 years, 4 months ago (2014-08-01 16:23:53 UTC) #3

danrubel

6 years, 4 months ago (2014-08-01 16:24:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/424543004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_completion.dart (right):

https://codereview.chromium.org/424543004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_completion.dart:58: Source source = new
FileBasedSource.con1(new JavaFile(file));
On 2014/07/31 22:28:47, scheglov wrote:
> We don't use FileBasedSource in server directly.
> We use ResourceProvider instead to allow in-memory sources in tests.
> I think you want to use AnalysisServer.getSource() here.

Good point. Much better that way. Done.

https://codereview.chromium.org/424543004/diff/1/pkg/analysis_services/lib/co...
File pkg/analysis_services/lib/completion/completion_computer.dart (right):

https://codereview.chromium.org/424543004/diff/1/pkg/analysis_services/lib/co...
pkg/analysis_services/lib/completion/completion_computer.dart:69: final  
SearchEngine searchEngine;
On 2014/07/31 22:28:47, scheglov wrote:
> nit: extra spaces
> Do you use our code formatter? :-)

Yes, but I forget sometimes because there is not yet a "format on save" option
:-)
Done.

Expand Messages | Collapse Messages