Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: pkg/analysis_services/test/completion/completion_computer_test.dart

Issue 424543004: incremental progress aligning code completion api to spec (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_services/lib/constants.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_services/test/completion/completion_computer_test.dart
diff --git a/pkg/analysis_services/test/completion/completion_computer_test.dart b/pkg/analysis_services/test/completion/completion_computer_test.dart
index d9b22d66f82e16b5a10138e813a2868318f367fe..6c974782ea3172751b4d2ab557ff452113c1bf75 100644
--- a/pkg/analysis_services/test/completion/completion_computer_test.dart
+++ b/pkg/analysis_services/test/completion/completion_computer_test.dart
@@ -6,24 +6,42 @@ library test.services.completion.suggestion;
import 'package:analysis_services/completion/completion_computer.dart';
import 'package:analysis_services/src/completion/top_level_computer.dart';
-import 'package:analysis_testing/abstract_single_unit.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:unittest/unittest.dart';
+import 'completion_test_util.dart';
+import 'package:analyzer/src/generated/source.dart';
+
main() {
groupSep = ' | ';
- runReflectiveTests(CompletionComputerTest);
+ runReflectiveTests(CompletionManagerTest);
+ runReflectiveTests(DartCompletionManagerTest);
}
@ReflectiveTestCase()
-class CompletionComputerTest extends AbstractSingleUnitTest {
+class CompletionManagerTest extends AbstractCompletionTest {
- test_topLevel() {
- CompletionComputer.create(null).then((computers) {
- assertContainsType(computers, TopLevelComputer);
- expect(computers, hasLength(1));
- });
+ test_dart() {
+ Source source = addSource('/does/not/exist.dart', '');
+ var manager = CompletionManager.create(source, 0, null);
+ expect(manager.runtimeType, DartCompletionManager);
+ }
+
+ test_html() {
+ Source source = addSource('/does/not/exist.html', '');
+ var manager = CompletionManager.create(source, 0, null);
+ expect(manager.runtimeType, NoOpCompletionManager);
+ }
+
+ test_other() {
+ Source source = addSource('/does/not/exist.foo', '');
+ var manager = CompletionManager.create(source, 0, null);
+ expect(manager.runtimeType, NoOpCompletionManager);
}
+}
+
+@ReflectiveTestCase()
+class DartCompletionManagerTest extends AbstractCompletionTest {
/// Assert that the list contains exactly one of the given type
void assertContainsType(List computers, Type type) {
@@ -42,4 +60,13 @@ class CompletionComputerTest extends AbstractSingleUnitTest {
fail(msg.toString());
}
}
+
+ test_topLevel() {
+ Source source = addSource('/does/not/exist.dart', '');
+ var manager = new DartCompletionManager(source, 0, searchEngine);
+ manager.generate().then((List<CompletionComputer> computers) {
+ assertContainsType(computers, TopLevelComputer);
+ expect(computers, hasLength(1));
+ });
+ }
}
« no previous file with comments | « pkg/analysis_services/lib/constants.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698