Support source_span spans in barback.

Support source_span spans in barback.

This releases barback 0.14.2, which supports both SourceSpan and Span.
It will be followed up with barback 0.15.0, which will remove support
for Span.

barback 0.14.1 will be added to third_party/pkg in a follow-up CL.

R=rnystrom@google.com
BUG=19930
Committed: https://code.google.com/p/dart/source/detail?r=38712

[Bob Nystrom, 2014-07-29 22:57:00]

lgtm

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
File sdk/lib/_internal/pub/asset/dart/serialize.dart (right):

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize.dart:48: /// Converts a serializable
map into a [Span].
Span -> SourceSpan.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize.dart:86: /// Converts a serializable
map into a [Location].
Location -> SourceLocation.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/preprocess.dart (right):

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:71: if (_scanner.scan(new
RegExp(r"//#[ \t]*"))) {
Why this change? Newlines?

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:121: // If there's no version
constraint, just check whether the package exists.
Long line.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:122: allowed =
_versions.containsKey(package);
Doing this check in both the if condition and else clause seems a bit awkward to
me. Or maybe it's just that it mixes parsing and evaluation. How about:

var constraint = VersionConstraint.any;
if (_scanner.scan(new RegExp(r"[^\n]+")) {
  try {
    constraint = new VersionConstraint.parse(_scanner.lastMatch[0]);
  } on FormatException { ... }
}

var allowed = _versions.containsKey(package) &&
constraint.allows(_versions[package]);

[nweiz, 2014-07-29 23:04:08]

Code review changes

[nweiz, 2014-07-29 23:04:18]

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
File sdk/lib/_internal/pub/asset/dart/serialize.dart (right):

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize.dart:48: /// Converts a serializable
map into a [Span].
On 2014/07/29 22:57:00, Bob Nystrom wrote:
> Span -> SourceSpan.

Done.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/asset/...
sdk/lib/_internal/pub/asset/dart/serialize.dart:86: /// Converts a serializable
map into a [Location].
On 2014/07/29 22:57:00, Bob Nystrom wrote:
> Location -> SourceLocation.

Done.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/preprocess.dart (right):

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:71: if (_scanner.scan(new
RegExp(r"//#[ \t]*"))) {
On 2014/07/29 22:57:00, Bob Nystrom wrote:
> Why this change? Newlines?

Yeah, \s consumes newlines and that's not what we want here. It broke in a
different regexp but I changed all of them.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:121: // If there's no version
constraint, just check whether the package exists.
On 2014/07/29 22:57:00, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/423823010/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/preprocess.dart:122: allowed =
_versions.containsKey(package);
On 2014/07/29 22:57:00, Bob Nystrom wrote:
> Doing this check in both the if condition and else clause seems a bit awkward
to
> me. Or maybe it's just that it mixes parsing and evaluation. How about:
> 
> var constraint = VersionConstraint.any;
> if (_scanner.scan(new RegExp(r"[^\n]+")) {
>   try {
>     constraint = new VersionConstraint.parse(_scanner.lastMatch[0]);
>   } on FormatException { ... }
> }
> 
> var allowed = _versions.containsKey(package) &&
> constraint.allows(_versions[package]);

Done.

[nweiz, 2014-07-29 23:05:36]

Committed patchset #2 manually as r38712 (presubmit successful).