Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart

Issue 423823010: Support source_span spans in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback.dart ('k') | sdk/lib/_internal/pub/lib/src/preprocess.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart
index 21e6fed60ed8b30bd5f262645cc25cb0bcd76907..5e2c306f80d6130510f6f6b99d8e3a97081bfc27 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart
@@ -13,6 +13,7 @@ import '../io.dart';
import '../package_graph.dart';
import '../preprocess.dart';
import '../sdk.dart' as sdk;
+import '../utils.dart';
/// An implementation of barback's [PackageProvider] interface so that barback
/// can find assets within pub packages.
@@ -37,13 +38,14 @@ class PubPackageProvider implements PackageProvider {
// Barback may not be in the package graph if there are no user-defined
// transformers being used at all. The "$pub" sources are still provided,
// but will never be loaded.
- var barback = _graph.packages['barback'];
- if (barback == null) {
+ if (!_graph.packages.containsKey("barback")) {
return new Future.value(new Asset.fromPath(id, file));
}
+ var versions = mapMap(_graph.packages,
+ value: (_, package) => package.version);
var contents = readTextFile(file);
- contents = preprocess(contents, barback.version, path.toUri(file));
+ contents = preprocess(contents, versions, path.toUri(file));
return new Future.value(new Asset.fromString(id, contents));
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/barback.dart ('k') | sdk/lib/_internal/pub/lib/src/preprocess.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698