Issue 422133002: add FUNCTION_TYPE_ALIAS to CompletionSuggestionKind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 422133002: add FUNCTION_TYPE_ALIAS to CompletionSuggestionKind (Closed)

Created:
6 years, 4 months ago by danrubel

Modified:
6 years, 4 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

add FUNCTION_TYPE_ALIAS to CompletionSuggestionKind BUG=dartbug/20188 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=38670

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -10 lines)			Patch
	M	pkg/analysis_server/test/completion_test.dart	View		4 chunks	+27 lines, -8 lines	0 comments	Download
	M	pkg/analysis_services/lib/completion/completion_suggestion.dart	View		4 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

lgtm Does this fix the test in pkg/analysis_server/test/integration/completion_domain_inttest.dart? If so, would you mind re-enabling that ...

6 years, 4 months ago (2014-07-28 20:38:03 UTC) #2

danrubel

Committed patchset #3 manually as r38670 (presubmit successful).

6 years, 4 months ago (2014-07-29 12:37:28 UTC) #3

danrubel

6 years, 4 months ago (2014-07-29 14:58:25 UTC) #4

Message was sent while issue was closed.

On 2014/07/28 20:38:03, Paul Berry wrote:
> lgtm
> 
> Does this fix the test in
> pkg/analysis_server/test/integration/completion_domain_inttest.dart?  If so,
> would you mind re-enabling that test (by removing the "fail_" prefix from
> fail_test_getSuggestions_string_var() and removing the dummy method
> test_placeholder())?
> 
> Thanks!

Unfortunately my CL did not fix the integration tests, but I did hook the stub
into the main test suite.
https://codereview.chromium.org/423083005/

Expand Messages | Collapse Messages