Issue 418433003: pkg/utf: fixed layout, added todos, updated docs and homepage pubspec links

Issue 418433003: pkg/utf: fixed layout, added todos, updated docs and homepage pubspec links (Closed)

Created:
6 years, 5 months ago by kevmoo

Modified:
6 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/utf: fixed layout, added todos, updated docs and homepage pubspec links R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38534

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+249 lines, -1676 lines)			Patch
D	pkg/utf/lib/constants.dart	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	pkg/utf/lib/list_range.dart	View	1 chunk	+0 lines, -78 lines	0 comments	Download
A +	pkg/utf/lib/src/constants.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/utf/lib/src/list_range.dart	View	5 chunks	+9 lines, -8 lines	0 comments	Download
A +	pkg/utf/lib/src/utf/utf16.dart	View	9 chunks	+12 lines, -153 lines	0 comments	Download
A +	pkg/utf/lib/src/utf/utf32.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
A +	pkg/utf/lib/src/utf/utf8.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
A +	pkg/utf/lib/src/utf/utf_stream.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
A	pkg/utf/lib/src/utf_16_code_unit_decoder.dart	View	1 chunk	+83 lines, -0 lines	0 comments	Download
A	pkg/utf/lib/src/util.dart	View	1 chunk	+78 lines, -0 lines	0 comments	Download
M	pkg/utf/lib/utf.dart	View	1 chunk	+12 lines, -6 lines	0 comments	Download
D	pkg/utf/lib/utf16.dart	View	1 chunk	+0 lines, -502 lines	0 comments	Download
D	pkg/utf/lib/utf32.dart	View	1 chunk	+0 lines, -342 lines	0 comments	Download
D	pkg/utf/lib/utf8.dart	View	1 chunk	+0 lines, -275 lines	0 comments	Download
D	pkg/utf/lib/utf_stream.dart	View	1 chunk	+0 lines, -237 lines	0 comments	Download
M	pkg/utf/pubspec.yaml	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	pkg/utf/test/unicode_core_test.dart	View	1 chunk	+30 lines, -31 lines	0 comments	Download
M	pkg/utf/test/utf16_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/utf/test/utf32_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/utf/test/utf82_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/utf/test/utf8_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/utf/test/utf_test.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

Changes LGTM, but I'm not very familiar with this package. Adding Florian who I believe ...

6 years, 5 months ago (2014-07-23 19:27:58 UTC) #2

kevmoo

On 2014/07/23 19:27:58, Siggi Cherem (dart-lang) wrote: > Changes LGTM, but I'm not very familiar ...

6 years, 5 months ago (2014-07-24 05:03:26 UTC) #3

kevmoo

6 years, 5 months ago (2014-07-24 05:05:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r38534 (presubmit successful).

Expand Messages | Collapse Messages