Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 418033006: Handle bad data in analysis server integration tests. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
jwren, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle bad data in analysis server integration tests. If bad data is received from the analysis server (e.g. a stacktrace), switch on debugging output, let the integration test run for 1 more second (to collect the entire stacktrace), and then fail the integration test. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M pkg/analysis_server/test/integration/integration_tests.dart View 4 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-24 16:53:08 UTC) #1
scheglov
LGTM
6 years, 5 months ago (2014-07-24 16:55:22 UTC) #2
Paul Berry
6 years, 5 months ago (2014-07-24 17:39:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698